Help With PHP Script.

Departed · 30-04-2005, 23:47

20WMT? when my band gets updated (6:50pm GMT) if you can solve this for me.
I get

Parse error: parse error, unexpected T_ELSE in /home/jdjokes/public_html/top10.php on line 7
when i access it;

heres the code:

PHP Code:

  <?php

include("config.php");

$query=mysql_query("SELECT * FROM jokes ORDER BY rating DESC LIMIT 10");

if(mysql_num_rows($query) == 0){

echo "There are no jokes currently in the top 10";

{

else{

echo '<table width="150" border="1">

<tr><td colspan="2">Joke</td></tr>';

$i=0;

while($r=mysql_fetch_array($query)){

$i++;

echo '<tr>

<td>'. $i. '</td>

<td><a href="joke.php?j='. $r['num']. '">'. $r['title']. '</a></td>

</tr>';

}

}

?>

So whats wrong with "else{" . :confused:

mck9235 · 01-05-2005, 00:04

Try this:

PHP Code:

  <?php

include("config.php");

$query=mysql_query("SELECT * FROM jokes ORDER BY rating DESC LIMIT 10");

if(mysql_num_rows($query) == 0)

{

echo "There are no jokes currently in the top 10";

}

else

{

echo '<table width="150" border="1">

<tr><td colspan="2">Joke</td></tr>';

$i=0;

while($r=mysql_fetch_array($query)){

$i++;

echo '<tr>

<td>'. $i. '</td>

<td><a href="joke.php?j='. $r['num']. '">'. $r['title']. '</a></td>

</tr>';

}

}

?>

You had a bracket going the wrong way.

Departed · 01-05-2005, 00:13

We've half sorted it over msn. I know have the code:

PHP Code:

  <?php 

include("config.php"); 

$query=mysql_query("SELECT * FROM `jokes` ORDER BY `rating` DESC LIMIT 10") or die(mysql_error());

if(mysql_num_rows($query) == 0) 

{ 

echo "There are no jokes currently in the top 10"; 

} 

else 

{ 

echo '<table width="150" border="1"> 

<tr><td colspan="2">Joke</td></tr>'; 

$i=0; 

while($r=mysql_fetch_array($query)){ 

$i++; 

echo '<tr> 

<td>'. $i. '</td> 

<td><a href="joke.php?j='. $r['num']. '">'. $r['title']. '</a></td> 

</tr>'; 

} 

} 

?>

And get "Unknown column 'rating' in 'order clause'" Now MySQL Doesnt want to work.... :confused:

(Sent some WMT? just for trying mck

)

**monaghan** · 01-05-2005, 08:35

I'd replace

PHP Code:

  $query=mysql_query("SELECT * FROM `jokes` ORDER BY `rating` DESC LIMIT 10")

with

PHP Code:

  $query = <<< SQLEND

SELECT * 

FROM jokes

ORDER BY rating

DESC 

LIMIT 10

SQLEND;

 
$query=mysql_query($query).....

As your code gets more complex, then this will aid readability.

Any reason for putting quotes round the table & field names ?

Any reason for doing a select *, this is generally bad practise, do you actually need every field ? If not then you're returning data that's not needed and adding load to your host and delay to the execution of your script.

mck9235 · 01-05-2005, 14:17

I put the quotes around the field+table name. It's perfectly acceptable, and is a good thing to practice. I only started becuase right now thats the only way queries will run on my computer.

**monaghan** · 01-05-2005, 22:18

Quoting is acceptable, however only required when you use a reserved word or a non-alpha/numeric within a name.

Quoting can be good, however simple meaningful names avoiding any requirement for quoting would probably be far better and more protable as many SQL enqines use differing quoting methods.

30-04-2005, 23:47	#1 (permalink)
Departed Senior Member Join Date: Apr 2005 Posts: 1,088 iTrader: 0 / 0%	Help With PHP Script. 20WMT? when my band gets updated (6:50pm GMT) if you can solve this for me. I get Parse error: parse error, unexpected T_ELSE in /home/jdjokes/public_html/top10.php on line 7 when i access it; heres the code: PHP Code: `<?php include("config.php"); $query=mysql_query("SELECT * FROM jokes ORDER BY rating DESC LIMIT 10"); if(mysql_num_rows($query) == 0){ echo "There are no jokes currently in the top 10"; { else{ echo '<table width="150" border="1"> <tr><td colspan="2">Joke</td></tr>'; $i=0; while($r=mysql_fetch_array($query)){ $i++; echo '<tr> <td>'. $i. '</td> <td><a href="joke.php?j='. $r['num']. '">'. $r['title']. '</a></td> </tr>'; } } ?>` So whats wrong with "else{" . :confused: __________________ -Gary

01-05-2005, 00:04	#2 (permalink)
mck9235 poke poke Join Date: Apr 2005 Posts: 134 iTrader: 0 / 0%	Try this: PHP Code: `<?php include("config.php"); $query=mysql_query("SELECT * FROM jokes ORDER BY rating DESC LIMIT 10"); if(mysql_num_rows($query) == 0) { echo "There are no jokes currently in the top 10"; } else { echo '<table width="150" border="1"> <tr><td colspan="2">Joke</td></tr>'; $i=0; while($r=mysql_fetch_array($query)){ $i++; echo '<tr> <td>'. $i. '</td> <td><a href="joke.php?j='. $r['num']. '">'. $r['title']. '</a></td> </tr>'; } } ?>` You had a bracket going the wrong way. __________________ \| - The Fast Track - \| Thanks to WMT for the new domain!

01-05-2005, 00:13	#3 (permalink)
Departed Senior Member Join Date: Apr 2005 Posts: 1,088 iTrader: 0 / 0%	We've half sorted it over msn. I know have the code: PHP Code: <?php include("config.php"); $query=mysql_query("SELECT * FROM `jokes` ORDER BY `rating` DESC LIMIT 10") or die(mysql_error()); if(mysql_num_rows($query) == 0) { echo "There are no jokes currently in the top 10"; } else { echo '<table width="150" border="1"> <tr><td colspan="2">Joke</td></tr>'; $i=0; while($r=mysql_fetch_array($query)){ $i++; echo '<tr> <td>'. $i. '</td> <td><a href="joke.php?j='. $r['num']. '">'. $r['title']. '</a></td> </tr>'; } } ?> And get "Unknown column 'rating' in 'order clause'" Now MySQL Doesnt want to work.... :confused: (Sent some WMT? just for trying mck ) __________________ -Gary

01-05-2005, 08:35	#4 (permalink)
monaghan Super Moderator Join Date: Mar 2005 Location: Herts, UK Posts: 1,030 iTrader: 1 / 100%	I'd replace PHP Code: $query=mysql_query("SELECT * FROM `jokes` ORDER BY `rating` DESC LIMIT 10") with PHP Code: `$query = <<< SQLEND SELECT * FROM jokes ORDER BY rating DESC LIMIT 10 SQLEND; $query=mysql_query($query).....` As your code gets more complex, then this will aid readability. Any reason for putting quotes round the table & field names ? Any reason for doing a select *, this is generally bad practise, do you actually need every field ? If not then you're returning data that's not needed and adding load to your host and delay to the execution of your script. __________________ Alex Monaghan - Monaghan Consultants Ltd Web hosting, ADSL, IT & Database consultancy Custom Web hosting on UK or USA servers using Linux (cPanel) or Windows (DotNetPanel) Mobile Phone Ringtones, Logos, Java Games & more

01-05-2005, 14:17	#5 (permalink)
mck9235 poke poke Join Date: Apr 2005 Posts: 134 iTrader: 0 / 0%	I put the quotes around the field+table name. It's perfectly acceptable, and is a good thing to practice. I only started becuase right now thats the only way queries will run on my computer. __________________ \| - The Fast Track - \| Thanks to WMT for the new domain!

01-05-2005, 22:18	#6 (permalink)
monaghan Super Moderator Join Date: Mar 2005 Location: Herts, UK Posts: 1,030 iTrader: 1 / 100%	Quoting is acceptable, however only required when you use a reserved word or a non-alpha/numeric within a name. Quoting can be good, however simple meaningful names avoiding any requirement for quoting would probably be far better and more protable as many SQL enqines use differing quoting methods. __________________ Alex Monaghan - Monaghan Consultants Ltd Web hosting, ADSL, IT & Database consultancy Custom Web hosting on UK or USA servers using Linux (cPanel) or Windows (DotNetPanel) Mobile Phone Ringtones, Logos, Java Games & more

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Survey Script	matty005	Php and MySQL	2	23-05-2006 10:50
script that does this	xeno	Website Development Forum	2	02-04-2006 12:02
Need a script for my site	nicklas	Website Design Forum	5	12-10-2005 18:20
Your most complicated script	Wistow	Programming / Scripting / Coding	13	09-04-2005 20:43
Looking for Script	cashoutusa	Programming / Scripting / Coding	4	02-03-2005 19:23

Help With PHP Script.

Help With PHP Script.

Similar Threads