PHP help for an amateur

wurzel · 09-10-2006, 19:01

Hi,

I am new on here and having trouble developing a php script for a web to email form. When I submit the form, the browser brings up a dialog box asking whether to open or save the 'sendmail.php'

This is the problematic script:

<?php
$email = $_REQUEST['email'] ;
$yourmessage = $_REQUEST['yourmessage'] ;
$name = $_REQUEST['name'] ;
$address = $_REQUEST['address'] ;
$postcode = $_REQUEST['postcode'] ;
$phoneno = $_REQUEST['phoneno'] ;
$preferred_means_of_contact = $_REQUEST['preferred_means_of_contact'] ;

mail( "myemail@mydomain.com", "Feedback Form Results",
"$yourmessage", "From: $email", "$embody = $name $address $postcode $phoneno $preferred_means_of_contact" ) ;
header( "Location: http://www.mydomain.co.uk/contact_thanks.html" ) ;
?>

Any help would be greatly appreciated.

**monaghan** · 09-10-2006, 23:25

I'd guess that your web server is not configured to execute PHP for a .php file.

Is this your own PC or a webhost ?

wurzel · 10-10-2006, 08:03

Thanks for the reply, Alex. The server is configured for php - in fact, the script works fine if I just request the email address and message - any more, and it creates problems.

**monaghan** · 10-10-2006, 09:23

Looks like a local config problem, bunged it onto my test server and it works OK with data passed in each field.

Don't any any more time at the moment to help, maybe later if I have time.

wurzel · 10-10-2006, 10:23

Thanks Alex, I will let you know if I manage to crack it in the meantime

wurzel · 10-10-2006, 16:08

I have modified the script and removed '$embody'. So the script no looks like this:

Code:

<?
  $email = $_REQUEST['email'] ;
  $yourmessage = $_REQUEST['yourmessage'] ;
  $name = $_REQUEST['name'] ;
  $address = $_REQUEST['address'] ;
  $postcode = $_REQUEST['postcode'] ;
  $phoneno = $_REQUEST['phoneno'] ;
  $preferred_means_of_contact = $_REQUEST['preferred_means_of_contact'] ;

  mail( "myname@btinternet.com", "Feedback Form Results",
    "$yourmessage", "From: $email", "$name", "$address", "$postcode", "$phoneno", "$preferred_means_of_contact");
  header( "Location: http://www.mydomain.co.uk/contact_thanks.html" );
?>

When I submit the form, the browser displays the following error message:

Quote:

Warning: mail() expects at most 5 parameters, 9 given in /home/fhlinux181/b/mydomain.co.uk/user/htdocs/sendmail.php on line 11

Warning: Cannot modify header information - headers already sent by (output started at /home/fhlinux181/b/mydomain.co.uk/user/htdocs/sendmail.php:11) in /home/fhlinux181/b/mydomain.co.uk/user/htdocs/sendmail.php on line 12

Any further help greatly appreciated.

**monaghan** · 10-10-2006, 16:35

Make the <?php the very first line in the file, otherwise the blank lines will be output prior to the php being executed. Once some content has been sent, then you are no longer able to send a header value.

Alternatively you can look at output buffering in the PHP manual if you want to send headers in your code after the content.

wurzel · 10-10-2006, 17:32

Tried putting php tag on first line - no difference.....will have a fiddle with output buffering tonight.

Many thanks

wurzel · 10-10-2006, 20:00

I have cracked it!!!!

Code:

<?php
  $email = $_REQUEST['email'] ;
  $yourmessage = $_REQUEST['yourmessage'] ;
  $name = $_REQUEST['name'] ;
  $address = $_REQUEST['address'] ;
  $postcode = $_REQUEST['postcode'] ;
  $phoneno = $_REQUEST['phoneno'] ;
  $actual_message = $yourmessage."\n--------------------\n".$name."\n".$address."\n".$postcode."\n".$phoneno."\n" ;
  
  mail( "myname@btinternet.com", "Feedback Form Results",
    "$actual_message", "From: $email");
  header( "Location: http://www.mydomain.co.uk/contact_thanks.html" );
?>

Did it by putting all the parameters into $actual_message, and then adding that to mail.

Thanks for your help, Alex

**monaghan** · 11-10-2006, 09:11

Good to see you're working now. Much better feeling when you resolve the issue yourself rather than having help

09-10-2006, 19:01	#1 (permalink)
wurzel Newbie Join Date: Oct 2006 Posts: 10 iTrader: 0 / 0%	PHP help for an amateur Hi, I am new on here and having trouble developing a php script for a web to email form. When I submit the form, the browser brings up a dialog box asking whether to open or save the 'sendmail.php' This is the problematic script: <?php $email = $_REQUEST['email'] ; $yourmessage = $_REQUEST['yourmessage'] ; $name = $_REQUEST['name'] ; $address = $_REQUEST['address'] ; $postcode = $_REQUEST['postcode'] ; $phoneno = $_REQUEST['phoneno'] ; $preferred_means_of_contact = $_REQUEST['preferred_means_of_contact'] ; mail( "myemail@mydomain.com", "Feedback Form Results", "$yourmessage", "From: $email", "$embody = $name $address $postcode $phoneno $preferred_means_of_contact" ) ; header( "Location: http://www.mydomain.co.uk/contact_thanks.html" ) ; ?> Any help would be greatly appreciated.

09-10-2006, 23:25	#2 (permalink)
monaghan Super Moderator Join Date: Mar 2005 Location: Herts, UK Posts: 1,030 iTrader: 1 / 100%	I'd guess that your web server is not configured to execute PHP for a .php file. Is this your own PC or a webhost ? __________________ Alex Monaghan - Monaghan Consultants Ltd Web hosting, ADSL, IT & Database consultancy Custom Web hosting on UK or USA servers using Linux (cPanel) or Windows (DotNetPanel) Mobile Phone Ringtones, Logos, Java Games & more

10-10-2006, 09:23	#4 (permalink)
monaghan Super Moderator Join Date: Mar 2005 Location: Herts, UK Posts: 1,030 iTrader: 1 / 100%	Looks like a local config problem, bunged it onto my test server and it works OK with data passed in each field. Don't any any more time at the moment to help, maybe later if I have time. __________________ Alex Monaghan - Monaghan Consultants Ltd Web hosting, ADSL, IT & Database consultancy Custom Web hosting on UK or USA servers using Linux (cPanel) or Windows (DotNetPanel) Mobile Phone Ringtones, Logos, Java Games & more

10-10-2006, 16:35	#7 (permalink)
monaghan Super Moderator Join Date: Mar 2005 Location: Herts, UK Posts: 1,030 iTrader: 1 / 100%	Make the <?php the very first line in the file, otherwise the blank lines will be output prior to the php being executed. Once some content has been sent, then you are no longer able to send a header value. Alternatively you can look at output buffering in the PHP manual if you want to send headers in your code after the content. __________________ Alex Monaghan - Monaghan Consultants Ltd Web hosting, ADSL, IT & Database consultancy Custom Web hosting on UK or USA servers using Linux (cPanel) or Windows (DotNetPanel) Mobile Phone Ringtones, Logos, Java Games & more

11-10-2006, 09:11	#10 (permalink)
monaghan Super Moderator Join Date: Mar 2005 Location: Herts, UK Posts: 1,030 iTrader: 1 / 100%	Good to see you're working now. Much better feeling when you resolve the issue yourself rather than having help __________________ Alex Monaghan - Monaghan Consultants Ltd Web hosting, ADSL, IT & Database consultancy Custom Web hosting on UK or USA servers using Linux (cPanel) or Windows (DotNetPanel) Mobile Phone Ringtones, Logos, Java Games & more

10-10-2006, 08:03	#3 (permalink)
wurzel Newbie Join Date: Oct 2006 Posts: 10 iTrader: 0 / 0%	Thanks for the reply, Alex. The server is configured for php - in fact, the script works fine if I just request the email address and message - any more, and it creates problems.

10-10-2006, 10:23	#5 (permalink)
wurzel Newbie Join Date: Oct 2006 Posts: 10 iTrader: 0 / 0%	Thanks Alex, I will let you know if I manage to crack it in the meantime

10-10-2006, 17:32	#8 (permalink)
wurzel Newbie Join Date: Oct 2006 Posts: 10 iTrader: 0 / 0%	Tried putting php tag on first line - no difference.....will have a fiddle with output buffering tonight. Many thanks

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode